Avoid lib install command hanging indefinitely in dependencies resolution.
#2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
topic: code
alessio-perugini
approved these changes
May 30, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2192 +/- ##
==========================================
- Coverage 62.89% 62.85% -0.05%
==========================================
Files 220 221 +1
Lines 19477 19463 -14
==========================================
- Hits 12251 12234 -17
- Misses 6141 6145 +4
+ Partials 1085 1084 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Avoid the dependencies resolver hanging in a very long loop trying to find an impossible libraries dependencies resolution.
A similar issue has been solved previously: #2140. This PR improves the previous one.
What is the current behavior?
The
lib installcommand seems stuck while in reality, it is just searching for a dependency solution.What is the new behavior?
The
lib installcommand returns an error early if a dependency is clearly not available.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Code patch here bugst/relaxed-semver#15
Fix #2135